linux-hardening - Re: [PATCH] gcc-plugins: Reorganize gimple includes for GCC 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Jan 2023 12:25:16 -0800 (PST)
From:   Palmer Dabbelt <palmer@...osinc.com>
To:     keescook@...omium.org
CC:     linux-hardening@...r.kernel.org, keescook@...omium.org,
        linux-kernel@...r.kernel.org
Subject:     Re: [PATCH] gcc-plugins: Reorganize gimple includes for GCC 13

On Wed, 18 Jan 2023 12:24:02 PST (-0800), keescook@...omium.org wrote:
> The gimple-iterator.h header must be included before gimple-fold.h
> starting with GCC 13. Reorganize gimple headers to work for all GCC
> versions.
>
> Reported-by: Palmer Dabbelt <palmer@...osinc.com>
> Link: https://lore.kernel.org/all/20230113173033.4380-1-palmer@rivosinc.com/
> Cc: linux-hardening@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  scripts/gcc-plugins/gcc-common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h
> index 9a1895747b15..84c730da36dd 100644
> --- a/scripts/gcc-plugins/gcc-common.h
> +++ b/scripts/gcc-plugins/gcc-common.h
> @@ -71,7 +71,9 @@
>  #include "varasm.h"
>  #include "stor-layout.h"
>  #include "internal-fn.h"
> +#include "gimple.h"
>  #include "gimple-expr.h"
> +#include "gimple-iterator.h"
>  #include "gimple-fold.h"
>  #include "context.h"
>  #include "tree-ssa-alias.h"
> @@ -85,10 +87,8 @@
>  #include "tree-eh.h"
>  #include "stmt.h"
>  #include "gimplify.h"
> -#include "gimple.h"
>  #include "tree-phinodes.h"
>  #include "tree-cfg.h"
> -#include "gimple-iterator.h"
>  #include "gimple-ssa.h"
>  #include "ssa-iterators.h"

Thanks, not sure how I missed it the first round.  My testing box is 
tied up, but I'v egot the same diff lying around somewhere so

Acked-by: Palmer Dabbelt <palmer@...osinc.com>
Reviewed-by: Palmer Dabbelt <palmer@...osinc.com>