linux-hardening - Re: [PATCH] scsi: megaraid_sas: Add flexible array member for SGLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167478863281.3972592.13981423399363284186.b4-ty@oracle.com>
Date:   Thu, 26 Jan 2023 22:22:59 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Kashyap Desai <kashyap.desai@...adcom.com>,
        Kees Cook <keescook@...omium.org>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Holger Kiehl <Holger.Kiehl@....de>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid_sas: Add flexible array member for SGLs

On Thu, 05 Jan 2023 21:32:00 -0800, Kees Cook wrote:

> struct MPI2_RAID_SCSI_IO_REQUEST ends with a single SGL, but expects to
> copy multiple. Add a flexible array member so the compiler can reason
> about the size of the memcpy(). This will avoid the run-time false
> positive warning:
> 
>   memcpy: detected field-spanning write (size 128) of single field "&r1_cmd->io_request->SGL" at drivers/scsi/megaraid/megaraid_sas_fusion.c:3326 (size 16)
> 
> [...]

Applied to 6.3/scsi-queue, thanks!

[1/1] scsi: megaraid_sas: Add flexible array member for SGLs
      https://git.kernel.org/mkp/scsi/c/a9a3629592ab

-- 
Martin K. Petersen	Oracle Linux Engineering