linux-hardening - Re: [PATCH] scripts/dtc: Replace 0-length arrays with flexible arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+fJk29-wGp02eFFru2Pn+m6eGKnVT6XJJyf-WtkxWw4g@mail.gmail.com>
Date:   Sun, 29 Jan 2023 15:20:28 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Frank Rowand <frowand.list@...il.com>, devicetree@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scripts/dtc: Replace 0-length arrays with flexible arrays

On Fri, Jan 27, 2023 at 6:24 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Fri, Jan 27, 2023 at 04:12:21PM -0800, Kees Cook wrote:
> > On Fri, Jan 27, 2023 at 05:44:13PM -0600, Rob Herring wrote:
> > > On Fri, Jan 27, 2023 at 4:41 PM Kees Cook <keescook@...omium.org> wrote:
> > > >
> > > > Replace the 0-length array with a C99 flexible array. Seen with GCC 13
> > > > under -fstrict-flex-arrays:
> > > >
> > > > In file included from ../lib/fdt_ro.c:2:
> > > > ../lib/../scripts/dtc/libfdt/fdt_ro.c: In function 'fdt_get_name':
> > > > ../lib/../scripts/dtc/libfdt/fdt_ro.c:319:24: warning: 'strrchr' reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
> > > >   319 |                 leaf = strrchr(nameptr, '/');
> > > >       |                        ^~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Cc: Rob Herring <robh+dt@...nel.org>
> > > > Cc: Frank Rowand <frowand.list@...il.com>
> > > > Cc: devicetree@...r.kernel.org
> > > > Signed-off-by: Kees Cook <keescook@...omium.org>
> > > > ---
> > > >  scripts/dtc/libfdt/fdt.h | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Changes to dtc/libfdt go to upstream dtc first and then we sync them back.
> >
> > Ah-ha, I've found it: https://github.com/dgibson/dtc
>
> Sent upstream: https://github.com/dgibson/dtc/pull/76

Maybe David will take that PR, but upstream is here[1]. Patches go to
devicetree-compiler@...r.kernel.org.

Rob

[1] https://git.kernel.org/pub/scm/utils/dtc/dtc.git