linux-hardening - Re: [PATCH 8/9] leaking_addresses: also skip canonical ftrace path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9gbus4wRYUqz7QS@tycho.pizza>
Date:   Mon, 30 Jan 2023 12:34:18 -0700
From:   Tycho Andersen <tycho@...ho.pizza>
To:     Ross Zwisler <zwisler@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Ross Zwisler <zwisler@...gle.com>,
        "Tobin C. Harding" <me@...in.cc>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-trace-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 8/9] leaking_addresses: also skip canonical ftrace path

On Mon, Jan 30, 2023 at 11:19:14AM -0700, Ross Zwisler wrote:
> The canonical location for the tracefs filesystem is at /sys/kernel/tracing.
> 
> But, from Documentation/trace/ftrace.rst:
> 
>   Before 4.1, all ftrace tracing control files were within the debugfs
>   file system, which is typically located at /sys/kernel/debug/tracing.
>   For backward compatibility, when mounting the debugfs file system,
>   the tracefs file system will be automatically mounted at:
> 
>   /sys/kernel/debug/tracing
> 
> scripts/leaking_addresses.pl only skipped this older debugfs path, so
> let's add the canonical path as well.
> 
> Signed-off-by: Ross Zwisler <zwisler@...gle.com>
> ---
>  scripts/leaking_addresses.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index 8f636a23bc3f..e695634d153d 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -61,6 +61,7 @@ my @skip_abs = (
>  	'/proc/device-tree',
>  	'/proc/1/syscall',
>  	'/sys/firmware/devicetree',
> +	'/sys/kernel/tracing/trace_pipe',
>  	'/sys/kernel/debug/tracing/trace_pipe',
>  	'/sys/kernel/security/apparmor/revision');

Thanks.

Acked-by: Tycho Andersen <tycho@...ho.pizza>