linux-hardening - Re: splat in ikheaders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230302144140.7a1ca7d3@kernel.org>
Date:   Thu, 2 Mar 2023 14:41:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Kees Cook <kees@...nel.org>, linux-hardening@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: splat in ikheaders_read (bpftrace)

On Thu, 2 Mar 2023 14:39:17 -0800 Kees Cook wrote:
> I've improved the reporting, and yeah, it's due to the declaration:
> 
>   memcpy: detected buffer overflow: 4096 byte read from buffer of size 1
> 
> But that's an easy fix -- this has been done in lots of other places. It
> needs to be an array, not a single char. (I'm surprised we hadn't seen
> this before.)

LGTM, feel free to add my Tested-by, if that matters :)
Thanks!