linux-hardening - Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bceb91fa-c94b-a0bf-a612-19fc5778810e@linaro.org>
Date:   Thu, 6 Apr 2023 20:32:30 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6115p-j606f: Enable ATH10K WiFi



On 6.04.2023 19:51, Dmitry Baryshkov wrote:
> On 06/04/2023 18:25, Konrad Dybcio wrote:
>> Enable the onboard QCA Wi-Fi. HW identifiers for reference:
>> qmi chip_id 0x320 chip_family 0x4001 board_id 0xff soc_id 0x400e0000
>>
>> Firmware sources:
>> /vendor/firmware_mnt/image/wlanmdsp.bin -> qcom/.../wlanmdsp.mbn
>> /vendor/firmware_mnt/image/bdwlan.bXX [1] -> [2] -> ath10k/.../board-2.bin
>> [3] -> ath10k/.../firmware-5.bin
>>
>> Not sure where 3 comes from on the device itself, gotta investigate that..
>>
>> According to [4], it's called WCN3990_STRAIT.
>>
>> [1] XX = board_id printed when the file is missing or by your downstream
>> kernel firmware loader in the dmesg; if XX=ff, use bdwlan.bin
> 
> Since the board_id is 0xff, please add qcom,ath10k-calibration-variant
Do I make up a name, or is there some convention?

I see Johan used "LE_X13S" in commit 2702f54f400ad3979632cdb76553772414f4c5e3.
Should I go with "LE_P11"?

> 
> Ideally, could you please send the bdwlan to ath10k for inclusion, see https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles .
The legal situation is ambiguous at best :/

Konrad
> 
>>
>> [2] https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
>> [3] https://github.com/kvalo/ath10k-firmware/blob/master/WCN3990/hw1.0/HL3.1/WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1/firmware-5.bin
>> [4] https://git.codelinaro.org/clo/la/platform/vendor/qcom-opensource/wlan/qca-wifi-host-cmn/-/blob/LA.VENDOR.1.0.r1-20700-WAIPIO.QSSI13.0/hif/src/hif_hw_version.h#L55
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> index 2aac25171dec..4ba8e59a27d8 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> @@ -315,6 +315,14 @@ &usb_hsphy {
>>       status = "okay";
>>   };
>>   +&wifi {
>> +    vdd-0.8-cx-mx-supply = <&pm6125_l8>;
>> +    vdd-1.8-xo-supply = <&pm6125_l16>;
>> +    vdd-1.3-rfa-supply = <&pm6125_l17>;
>> +    vdd-3.3-ch0-supply = <&pm6125_l23>;
>> +    status = "okay";
>> +};
>> +
>>   &xo_board {
>>       clock-frequency = <19200000>;
>>   };
>>
>