linux-hardening - Re: [PATCH v3] NFSD: Remove open coding of string copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADmuW3V_J+5ikfArEmj8_a9HYpX57rON6BE9fV5bXsix+XtqxQ@mail.gmail.com>
Date:   Mon, 15 May 2023 10:30:57 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Chuck Lever <chuck.lever@...cle.com>,
        linux-hardening@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] NFSD: Remove open coding of string copy

On Mon, May 15, 2023 at 7:21 AM Jeff Layton <jlayton@...nel.org> wrote:
>
> On Mon, 2023-05-15 at 02:40 +0000, Azeem Shaikh wrote:
> > Instead of open coding a __dynamic_array(), use the __string() and
> > __assign_str() helper macros that exist for this kind of use case.
> >
> > Part of an effort to remove deprecated strlcpy() [1] completely from the
> > kernel[2].
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Fixes: 3c92fba557c6 ("NFSD: Enhance the nfsd_cb_setup tracepoint")
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
> > ---

v1 and v2 links for posterity.
v1: https://lore.kernel.org/all/20230510220952.3507366-1-azeemshaikh38@gmail.com/
v2: https://lore.kernel.org/all/20230512145356.396567-1-azeemshaikh38@gmail.com/

> Reviewed-by: Jeff Layton <jlayton@...nel.org>

Thanks!