linux-hardening - Re: [PATCH] scsi: qla2xxx: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADmuW3UvuHvVHnQx3AGZso2N6JwnJ_5--jHxJPa+q-FFFz6N7Q@mail.gmail.com>
Date:   Thu, 18 May 2023 00:48:02 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        linux-hardening@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>
Subject: Re: [PATCH] scsi: qla2xxx: Replace all non-returning strlcpy with strscpy

On Wed, May 17, 2023 at 10:11 AM Azeem Shaikh <azeemshaikh38@...il.com> wrote:
>
> On Tue, May 16, 2023 at 9:42 PM Martin K. Petersen
> <martin.petersen@...cle.com> wrote:
> >
> >
> > Azeem,
> >
> > > strlcpy() reads the entire source buffer first. This read may exceed
> > > the destination size limit. This is both inefficient and can lead to
> > > linear read overflows if a source string is not NUL-terminated [1]. In
> > > an effort to remove strlcpy() completely [2], replace strlcpy() here
> > > with strscpy(). No return values were used, so direct replacement is
> > > safe.
> >
> > Applied to 6.5/scsi-staging, thanks!
> >
>
> Thanks a lot for the quick response Martin (on this and other patches
> too). Just for my understanding, do you mind pointing me to the
> 6.5/scsi-staging tree?

Found it: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=6.5/scsi-staging