linux-hardening - Re: [PATCH] scsi: qedi: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168478437625.244538.15778765475911379516.b4-ty@chromium.org>
Date:   Mon, 22 May 2023 12:39:41 -0700
From:   Kees Cook <keescook@...omium.org>
To:     njavali@...vell.com, mrangankar@...vell.com,
        GR-QLogic-Storage-Upstream@...vell.com, azeemshaikh38@...il.com
Cc:     Kees Cook <keescook@...omium.org>, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, linux-kernel@...r.kernel.org,
        jejb@...ux.ibm.com, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: qedi: Replace all non-returning strlcpy with strscpy

On Wed, 17 May 2023 14:35:09 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] scsi: qedi: Replace all non-returning strlcpy with strscpy
      https://git.kernel.org/kees/c/66f7f4013aa9

-- 
Kees Cook