linux-hardening - Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq18rdgm1mo.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 22 May 2023 18:41:58 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     azeemshaikh38@...il.com, Adam Radford <aradford@...il.com>,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, jejb@...ux.ibm.com,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] scsi: 3w-9xxx: Replace all non-returning strlcpy with
 strscpy


Kees,

> On Wed, 17 May 2023 14:29:55 +0000, Azeem Shaikh wrote:
>> strlcpy() reads the entire source buffer first.
>> This read may exceed the destination size limit.
>> This is both inefficient and can lead to linear read
>> overflows if a source string is not NUL-terminated [1].
>> In an effort to remove strlcpy() completely [2], replace
>> strlcpy() here with strscpy().
>> No return values were used, so direct replacement is safe.
>> 
>> [...]
>
> Applied to for-next/hardening, thanks!
>
> [1/1] scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
>       https://git.kernel.org/kees/c/fa36c95739ab

Are you planning on sending these? That's fine with me, just need to
know if I should close them in patchwork...

-- 
Martin K. Petersen	Oracle Linux Engineering