linux-hardening - Re: [PATCH] scsi: qla4xxx: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168479035945.1118074.16320595294990863793.b4-ty@oracle.com>
Date:   Mon, 22 May 2023 18:46:14 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Nilesh Javali <njavali@...vell.com>,
        Manish Rangankar <mrangankar@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        Azeem Shaikh <azeemshaikh38@...il.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-hardening@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>
Subject: Re: [PATCH] scsi: qla4xxx: Replace all non-returning strlcpy with strscpy

On Tue, 16 May 2023 02:53:55 +0000, Azeem Shaikh wrote:

> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Applied to 6.5/scsi-queue, thanks!

[1/1] scsi: qla4xxx: Replace all non-returning strlcpy with strscpy
      https://git.kernel.org/mkp/scsi/c/41300cc989c2

-- 
Martin K. Petersen	Oracle Linux Engineering