linux-hardening - Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU70uRxnMNb8KCJe8M3BRPPxowRXtj+POcrh+KLkfQyAA@mail.gmail.com>
Date:   Wed, 31 May 2023 10:05:03 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Richard Weinberger <richard@....at>
Cc:     Kees Cook <kees@...nel.org>,
        Azeem Shaikh <azeemshaikh38@...il.com>,
        kernel test robot <lkp@...el.com>,
        Maxim Krasnyansky <maxk@....qualcomm.com>,
        oe-kbuild-all <oe-kbuild-all@...ts.linux.dev>,
        linux-hardening@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        anton ivanov <anton.ivanov@...bridgegreys.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-um <linux-um@...ts.infradead.org>
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy

On Wed, May 31, 2023 at 8:23 AM Richard Weinberger <richard@....at> wrote:
> ----- Ursprüngliche Mail -----
> >>>> arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of
> >>>> function 'strscpy'; did you mean 'strncpy'?
> >>>> [-Werror=implicit-function-declaration]
> >>     149 |                 strscpy(ifr.ifr_name, pri->dev_name,
> >>     sizeof(ifr.ifr_name));
> >>         |                 ^~~~~~~
> >>         |                 strncpy
> >>   cc1: some warnings being treated as errors
> >
> > Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this
> > strlcpy for now.
>
> Well, actually it's another case of "not even compile tested". :-(

"But the AI said it was correct?!?" ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds