linux-hardening - Re: [PATCH] bpf: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168553142122.8778.8422261276573581725.git-patchwork-notify@kernel.org>
Date:   Wed, 31 May 2023 11:10:21 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Azeem Shaikh <azeemshaikh38@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        linux-hardening@...r.kernel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, iii@...ux.ibm.com
Subject: Re: [PATCH] bpf: Replace all non-returning strlcpy with strscpy

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Tue, 30 May 2023 15:56:59 +0000 you wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Here is the summary with links:
  - bpf: Replace all non-returning strlcpy with strscpy
    https://git.kernel.org/bpf/bpf-next/c/ffadc372529e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html