linux-hardening - Re: [PATCH] scsi: libfcoe: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADmuW3V=b3SOvijU0MPCBadpcRBtRYfT5eWVQOvL8WH-z-BqbA@mail.gmail.com>
Date:   Wed, 31 May 2023 18:40:24 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Hannes Reinecke <hare@...e.de>, linux-hardening@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>
Subject: Re: [PATCH] scsi: libfcoe: Replace all non-returning strlcpy with strscpy

On Wed, May 31, 2023 at 6:03 PM Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>
>
> Azeem,
>
> > strlcpy() reads the entire source buffer first. This read may exceed
> > the destination size limit. This is both inefficient and can lead to
> > linear read overflows if a source string is not NUL-terminated [1]. In
> > an effort to remove strlcpy() completely [2], replace strlcpy() here
> > with strscpy(). No return values were used, so direct replacement is
> > safe.
>
> Applied to 6.5/scsi-staging!

Thanks Martin!

>
> PS. It would help if you could submit changes like these as a series in
> the future so I don't have to track each patch individually.
>

Sure, I can do that.