linux-hardening - Re: [PATCH v2] riscv/purgatory: Do not use fortified string functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-cb8265a9-018d-483b-8de9-b7b2eaa5557f@palmer-ri-x1c9a>
Date:   Thu, 01 Jun 2023 14:04:30 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     keescook@...omium.org
CC:     Paul Walmsley <paul.walmsley@...ive.com>, ndesaulniers@...gle.com,
        linux-kernel@...r.kernel.org, gustavoars@...nel.org,
        linux@...mhuis.info, heiko.stuebner@...ll.eu,
        linux-hardening@...r.kernel.org, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org, joanbrugueram@...il.com,
        masahiroy@...nel.org, Conor Dooley <conor.dooley@...rochip.com>,
        ajones@...tanamicro.com, hi@...ssa.is
Subject:     Re: [PATCH v2] riscv/purgatory: Do not use fortified string functions

On Thu, 01 Jun 2023 13:31:33 PDT (-0700), keescook@...omium.org wrote:
> On Thu, Jun 01, 2023 at 01:17:03PM -0700, Palmer Dabbelt wrote:
>> On Thu, 01 Jun 2023 11:27:03 PDT (-0700), keescook@...omium.org wrote:
>> > On Thu, 1 Jun 2023 09:00:28 -0700, Kees Cook wrote:
>> > > With the addition of -fstrict-flex-arrays=3, struct sha256_state's
>> > > trailing array is no longer ignored by CONFIG_FORTIFY_SOURCE:
>> > >
>> > > struct sha256_state {
>> > >         u32 state[SHA256_DIGEST_SIZE / 4];
>> > >         u64 count;
>> > >         u8 buf[SHA256_BLOCK_SIZE];
>> > > };
>> > >
>> > > [...]
>> >
>> > Applied to for-next/hardening, thanks!
>> >
>> > [1/1] riscv/purgatory: Do not use fortified string functions
>> >       https://git.kernel.org/kees/c/ca2ca08f479d
>>
>> Sorry, I'd just applied this to riscv/fixes as well.  I can drop it if you
>> want?  I was going to send a PR tomorrow, just LMK.
>
> I'm fine either way. I was carrying each arch's fix just since it was
> related to the -fstrict-flex-arrays=3 patch in the hardening tree.

Works for me, I'll drop it.

Reviewed-by: Palmer Dabbelt <palmer@...osinc.com>
Acked-by: Palmer Dabbelt <palmer@...osinc.com>

The bots will probably get confussed and it was briefly visible to 
linux-next, so there might be a bit of spam.