linux-hardening - Re: [PATCH] jfs: Use unsigned variable for length calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <808fe90f-9171-54e6-2170-224d4048e333@oracle.com>
Date:   Fri, 2 Jun 2023 08:37:17 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Christian Brauner <brauner@...nel.org>,
        Kees Cook <keescook@...omium.org>
Cc:     Dave Chinner <dchinner@...hat.com>,
        jfs-discussion@...ts.sourceforge.net,
        "Dr. David Alan Gilbert" <linux@...blig.org>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
        Dave Kleikamp <shaggy@...nel.org>
Subject: Re: [PATCH] jfs: Use unsigned variable for length calculations

I apologize to all of you for letting this one go so long.

Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

On 6/2/23 3:32AM, Christian Brauner wrote:
> On Sat, 04 Feb 2023 10:33:56 -0800, Kees Cook wrote:
>> To avoid confusing the compiler about possible negative sizes, switch
>> "ssize" which can never be negative from int to u32.  Seen with GCC 13:
>>
>> ../fs/jfs/namei.c: In function 'jfs_symlink': ../include/linux/fortify-string.h:57:33: warning: '__builtin_memcpy' pointer overflow between offset 0 and size [-2147483648, -1]
>> [-Warray-bounds=]
>>     57 | #define __underlying_memcpy     __builtin_memcpy
>>        |                                 ^
>> ...
>> ../fs/jfs/namei.c:950:17: note: in expansion of macro 'memcpy'
>>    950 |                 memcpy(ip->i_link, name, ssize);
>>        |                 ^~~~~~
>>
>> [...]
> 
> Applied to the vfs.misc branch of the vfs/vfs.git tree.
> Patches in the vfs.misc branch should appear in linux-next soon.
> 
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
> 
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.misc
> 
> [1/1] jfs: Use unsigned variable for length calculations
>        https://git.kernel.org/vfs/vfs/c/2d6e1895d440