linux-hardening - Re: [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADmuW3U6WU7f0ifZun615xNoZAwvH-R8=2JMqCngp7rpeu5-GQ@mail.gmail.com>
Date:   Wed, 14 Jun 2023 11:23:04 -0400
From:   Azeem Shaikh <azeemshaikh38@...il.com>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     linux-hardening@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy()

On Wed, Jun 14, 2023 at 11:15 AM Kalle Valo <kvalo@...nel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@...il.com> writes:
>
> > On Wed, Jun 14, 2023 at 10:24 AM Kalle Valo <kvalo@...nel.org> wrote:
> >
> >>
> >> Azeem Shaikh <azeemshaikh38@...il.com> writes:
> >>
> >> > strlcpy() reads the entire source buffer first.
> >> > This read may exceed the destination size limit.
> >> > This is both inefficient and can lead to linear read
> >> > overflows if a source string is not NUL-terminated [1].
> >> > In an effort to remove strlcpy() completely [2], replace
> >> > strlcpy() here with strscpy().
> >> >
> >> > Direct replacement is safe here since WIPHY_ASSIGN is only used by
> >> > TRACE macros and the return values are ignored.
> >> >
> >> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> >> > [2] https://github.com/KSPP/linux/issues/89
> >> >
> >> > Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>
> >> > ---
> >> > v1: https://lore.kernel.org/all/20230612232301.2572316-1-azeemshaikh38@gmail.com/
> >> > v2: https://lore.kernel.org/all/20230614134552.2108471-1-azeemshaikh38@gmail.com/
> >>
> >> In the change log (after the "---" line) you should also describe what
> >> changes you made, more info in the wiki below. In this case it's clear
> >> as the patch is simple but please keep this in mind for future patches.
> >>
> >> No need to resend because of this.
> >>
> >
> > Thanks Kalle. I did have the below line in my changelog. For future
> > patches, do you mean that changelog descriptions need to be more
> > specific than this? For example - updated title from "x" -> "y"?
> >
> >> Changes from v1 and v2 - updated patch title.
>
> Ah, I missed that because the format was not what we usually use. I
> recommend something like this:
>
> v3:
>
> * add bar
>
> v2:
>
> * https://
> * fix foo
>
> v1:
>
> * https://
>

Got it, thanks a lot!