linux-hardening - Re: [PATCH] kallsyms: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306141053.8C337829@keescook>
Date:   Wed, 14 Jun 2023 10:53:22 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Azeem Shaikh <azeemshaikh38@...il.com>
Cc:     linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luis Chamberlain <mcgrof@...nel.org>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Alan Maguire <alan.maguire@...cle.com>,
        Maninder Singh <maninder1.s@...sung.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Miroslav Benes <mbenes@...e.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christian König <christian.koenig@....com>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        bpf@...r.kernel.org
Subject: Re: [PATCH] kallsyms: Replace all non-returning strlcpy with strscpy

On Wed, Jun 14, 2023 at 01:03:54AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
> 
> Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook