linux-hardening - Re: [PATCH] sh: Replace all non-returning strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168676826702.1963449.9061022814058323294.b4-ty@chromium.org>
Date:   Wed, 14 Jun 2023 11:44:29 -0700
From:   Kees Cook <keescook@...omium.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        ysato@...rs.sourceforge.jp, azeemshaikh38@...il.com,
        dalias@...c.org
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        rdunlap@...radead.org, linux-sh@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] sh: Replace all non-returning strlcpy with strscpy

On Tue, 30 May 2023 16:30:41 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Build tested with sh4 GCC 13.1 from:
https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/

with defconfig and:
	CONFIG_CPU_SUBTYPE_SH7343=y
	CONFIG_SH_DMA=y
	CONFIG_SH_DMA_API=y

Applied to for-next/hardening, thanks!

[1/1] sh: Replace all non-returning strlcpy with strscpy
      https://git.kernel.org/kees/c/ca64da3052be

-- 
Kees Cook