linux-hardening - Re: [PATCH] pstore: ramoops: support pmsg size larger than kmalloc limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230628184820.1375994-1-yuxiaozhang@google.com>
Date:   Wed, 28 Jun 2023 11:48:20 -0700
From:   Yuxiao Zhang <yuxiaozhang@...gle.com>
To:     Kees Cook <keescook@...omium.org>,
        "'Guilherme G . Piccoli'" <gpiccoli@...lia.com>
Cc:     Tony Luck <tony.luck@...el.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        wak@...gle.com
Subject: Re: [PATCH] pstore: ramoops: support pmsg size larger than kmalloc limitation

Thanks for the review Kees.

>And yes, Greg's questions are all good -- fixing syntax and adding size
details in the commit log would be appreciated.

Sure, will send another patch to address this.

Hi Guilherme, thanks for testing this patch.

>But when I tried to increase the record size in ramoops, I got this error: https://termbin.com/b12e

What record type are you testing? I should have mention that this patch is only for pmsg use case on ramoops (I mentioned it in the original thread but need to start a new one due to format issue).

>Also - Kees certainly knows that way better, but - are we 100% sure that
the region for pstore can be non-contiguous? For some reason, I always
thought this was a requirement

Right, that is why this patch only touches the pstore ram path, I am not sure how things will go if it is block device backed.

Thanks,
-Yuxiao Zhang