linux-hardening - Re: [PATCH v3 0/2] pstore: Replace crypto API compression with zlib calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168926982309.199014.17782001136753188986.b4-ty@chromium.org>
Date:   Thu, 13 Jul 2023 10:37:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     linux-hardening@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        Eric Biggers <ebiggers@...nel.org>
Subject: Re: [PATCH v3 0/2] pstore: Replace crypto API compression with zlib calls


On Wed, 12 Jul 2023 18:23:30 +0200, Ard Biesheuvel wrote:
> The pstore layer implements support for compression of kernel log
> output, using a variety of compression algorithms provided by the
> [deprecated] crypto API 'comp' interface.
> 
> This appears to have been somebody's pet project rather than a solution
> to a real problem: the original deflate compression is reasonably fast,
> compresses well and is comparatively small in terms of code footprint,
> and so the flexibility that the crypto API integration provides does
> little more than complicate the code for no reason.
> 
> [...]

Applied, thanks!

[1/2] pstore: Remove worst-case compression size logic
      https://git.kernel.org/kees/c/32a9ef435140
[2/2] pstore: Replace crypto API compression with zlib_deflate library calls
      https://git.kernel.org/kees/c/efe5be6664c8

Best regards,
-- 
Kees Cook