linux-hardening - Re: [PATCHSET 0/3] xfs: ubsan fixes for 6.5-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202307141410.A83FB7167@keescook>
Date:   Fri, 14 Jul 2023 14:11:48 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     david@...morbit.com, linux-xfs@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCHSET 0/3] xfs: ubsan fixes for 6.5-rc2

On Fri, Jul 14, 2023 at 07:42:19AM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> Fix some UBSAN complaints, since apparently they don't allow flex array
> declarations with array[1] anymore.

Thanks for finding the best way to do this! Everything looks sane to me,
and the changes in sizes look correctly identified/checked.

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=ubsan-fixes-6.5
> ---
>  fs/xfs/libxfs/xfs_da_format.h |   75 ++++++++++++++++++++++++++++++++++++-----
>  fs/xfs/libxfs/xfs_fs.h        |    4 +-
>  fs/xfs/xfs_ondisk.h           |    5 ++-
>  3 files changed, 71 insertions(+), 13 deletions(-)
> 

-- 
Kees Cook