linux-hardening - Re: [PATCH] ocfs2: Use regular seq_show_option for osb_cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2023 09:18:11 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Kees Cook <keescook@...omium.org>, Mark Fasheh <mark@...heh.com>,
        akpm <akpm@...ux-foundation.org>
Cc:     Joel Becker <jlbec@...lplan.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Use regular seq_show_option for osb_cluster_stack



On 7/27/23 5:59 AM, Kees Cook wrote:
> While cleaning up seq_show_option_n()'s use of strncpy, it was noticed
> that the osb_cluster_stack member is always NUL-terminated, so there is
> no need to use the special seq_show_option_n() routine. Replace it with
> the standard seq_show_option() routine.
> 
> Cc: Mark Fasheh <mark@...heh.com>
> Cc: Joel Becker <jlbec@...lplan.org>
> Cc: Joseph Qi <joseph.qi@...ux.alibaba.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: ocfs2-devel@...ts.linux.dev
> Signed-off-by: Kees Cook <keescook@...omium.org>

Looks good.

Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
> ---
>  fs/ocfs2/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 988d1c076861..6b906424902b 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -1517,8 +1517,7 @@ static int ocfs2_show_options(struct seq_file *s, struct dentry *root)
>  		seq_printf(s, ",localflocks,");
>  
>  	if (osb->osb_cluster_stack[0])
> -		seq_show_option_n(s, "cluster_stack", osb->osb_cluster_stack,
> -				  OCFS2_STACK_LABEL_LEN);
> +		seq_show_option(s, "cluster_stack", osb->osb_cluster_stack);
>  	if (opts & OCFS2_MOUNT_USRQUOTA)
>  		seq_printf(s, ",usrquota");
>  	if (opts & OCFS2_MOUNT_GRPQUOTA)