linux-hardening - Re: [PATCH] seq_file: seq_show_option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169047297893.2399768.3235005834445433615.b4-ty@chromium.org>
Date:   Thu, 27 Jul 2023 08:49:40 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Muchun Song <muchun.song@...ux.dev>,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] seq_file: seq_show_option_n() is used for precise sizes


On Wed, 26 Jul 2023 14:59:57 -0700, Kees Cook wrote:
> When seq_show_option_n() is used, it is for non-string memory that
> happens to be printable bytes. As such, we must use memcpy() to copy the
> bytes and then explicitly NUL-terminate the result.
> 
> 

Applied, thanks!

[1/1] seq_file: seq_show_option_n() is used for precise sizes
      https://git.kernel.org/kees/c/630fdd592912

Best regards,
-- 
Kees Cook