linux-hardening - RE: [Intel-wired-lan] [PATCH net-next 3/3] virtchnl: fix fake 1-elem arrays for structures allocated as `nents`

Open Source and information security mailing list archives

Message-ID: <BL0PR11MB35212DF83A9AAF2E1D2D3A628F15A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date:   Wed, 16 Aug 2023 12:51:42 +0000
From:   "Romanowski, Rafal" <rafal.romanowski@...el.com>
To:     Kees Cook <keescook@...omium.org>,
        "Lobakin, Aleksander" <aleksander.lobakin@...el.com>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Zaremba, Larysa" <larysa.zaremba@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 3/3] virtchnl: fix fake 1-elem
 arrays for structures allocated as `nents`

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kees Cook
> Sent: piątek, 4 sierpnia 2023 10:30
> To: Lobakin, Aleksander <aleksander.lobakin@...el.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; Zaremba,
> Larysa <larysa.zaremba@...el.com>; netdev@...r.kernel.org; Gustavo A. R.
> Silva <gustavoars@...nel.org>; linux-kernel@...r.kernel.org; Eric Dumazet
> <edumazet@...gle.com>; intel-wired-lan@...ts.osuosl.org; linux-
> hardening@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 3/3] virtchnl: fix fake 1-elem
> arrays for structures allocated as `nents`
> 
> On Fri, Jul 28, 2023 at 05:52:07PM +0200, Alexander Lobakin wrote:
> > Finally, fix 3 structures which are allocated technically correctly,
> > i.e. the calculated size equals to the one that struct_size() would
> > return, except for sizeof(). For &virtchnl_vlan_filter_list_v2, use
> > the same approach when there are no enough space as taken previously
> > for &virtchnl_vlan_filter_list, i.e. let the maximum size be
> > calculated automatically instead of trying to guestimate it using maths.
> >
> > Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> --
> Kees Cook
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives