linux-hardening - Re: [PATCH] Revert "ACPI, APEI, use raw spinlock in ERST"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6oqbigj.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Wed, 23 Aug 2023 10:28:28 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Jrn Engel <joern@...estorage.com>
Cc:     Uday Shankar <ushankar@...estorage.com>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
        Borislav Petkov <bp@...en8.de>,
        Len Brown <len.brown@...el.com>,
        linux-hardening@...r.kernel.org, linux-acpi@...r.kernel.org,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Subject: Re: [PATCH] Revert "ACPI, APEI, use raw spinlock in ERST"

Jrn Engel <joern@...estorage.com> writes:

> On Tue, Aug 22, 2023 at 09:56:38AM +0800, Huang, Ying wrote:
>> 
>> ERST is mainly used to log the hardware error.  While, hardware error
>> may be reported via NMI (e.g., ACPI APEI GHES NMI), so we need to call
>> ERST functions in NMI handlers.  Where normal spinlock cannot be used
>> because they will be converted to sleepable rt_mutex in RT kernel.
>
> Non-sleeping spinlocks cannot be used in NMI context either.
> raw_spin_lock_irqsave() will prevent regular interrupts, but not NMI.
> So taking a spinlock inside an NMI can trigger a deadlock.

Thanks reminding from Uday, trylock can avoid the deadlock.  More
details in reply to Uday's email.

--
Best Regards,
Huang, Ying

> Am I missing something here?
>
> Jrn
>
> --
> All art is but imitation of nature.
> -- Lucius Annaeus Seneca