[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <75466db4-3d19-33f6-b2de-db714186a96b@linaro.org>
Date: Mon, 11 Sep 2023 13:08:48 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mukesh Ojha <quic_mojha@...cinc.com>, corbet@....net,
agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, keescook@...omium.org, tony.luck@...el.com,
gpiccoli@...lia.com, mathieu.poirier@...aro.org,
catalin.marinas@....com, will@...nel.org, linus.walleij@...aro.org,
andy.shevchenko@...il.com, vigneshr@...com, nm@...com,
matthias.bgg@...il.com, kgene@...nel.org, alim.akhtar@...sung.com,
bmasney@...hat.com, quic_tsoni@...cinc.com
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-hardening@...r.kernel.org,
linux-remoteproc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v5 07/17] soc: qcom: minidump: Add pending region
registration
On 09/09/2023 22:16, Mukesh Ojha wrote:
> static int qcom_apss_minidump_probe(struct platform_device *pdev)
> {
> struct minidump_global_toc *mdgtoc;
> @@ -571,7 +688,10 @@ static int qcom_apss_minidump_probe(struct platform_device *pdev)
> return ret;
> }
>
> + mutex_lock(&md_plist.plock);
> platform_set_drvdata(pdev, md);
Why this is locked?
> + qcom_apss_register_pending_regions(md);
Why this one is locked? It seems ordering of your operations is not
correct if you need to lock the providers probe().
> + mutex_unlock(&md_plist.plock);
Best regards,
Krzysztof
Powered by blists - more mailing lists