linux-hardening - Re: [PATCH] leds: qcom-lpg: Annotate struct lpg_led with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2023 14:47:56 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kees Cook <keescook@...omium.org>, Pavel Machek <pavel@....cz>
Cc:     Lee Jones <lee@...nel.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Douglas Anderson <dianders@...omium.org>,
        Anjelique Melendez <quic_amelende@...cinc.com>,
        linux-leds@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Luca Weiss <luca@...tu.xyz>, Lu Hongfei <luhongfei@...o.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] leds: qcom-lpg: Annotate struct lpg_led with __counted_by



On 9/15/23 14:11, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct lpg_led.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Pavel Machek <pavel@....cz>
> Cc: Lee Jones <lee@...nel.org>
> Cc: Bjorn Andersson <quic_bjorande@...cinc.com>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Anjelique Melendez <quic_amelende@...cinc.com>
> Cc: linux-leds@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
-- 
Gustavo

> ---
>   drivers/leds/rgb/leds-qcom-lpg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index df469aaa7e6e..7d93e02a030a 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -173,7 +173,7 @@ struct lpg_led {
>   	struct led_classdev_mc mcdev;
>   
>   	unsigned int num_channels;
> -	struct lpg_channel *channels[];
> +	struct lpg_channel *channels[] __counted_by(num_channels);
>   };
>   
>   /**