linux-hardening - Re: [PATCH] leds: mt6370: Annotate struct mt6370_priv with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6421279-e2a6-8ad5-cc46-0b292eb1223d@embeddedor.com>
Date:   Fri, 15 Sep 2023 14:47:44 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kees Cook <keescook@...omium.org>, Pavel Machek <pavel@....cz>
Cc:     Lee Jones <lee@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Alice Chen <alice_chen@...htek.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        ChiaEn Wu <chiaen_wu@...htek.com>,
        kernel test robot <lkp@...el.com>,
        linux-leds@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] leds: mt6370: Annotate struct mt6370_priv with
 __counted_by



On 9/15/23 14:10, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mt6370_priv.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Pavel Machek <pavel@....cz>
> Cc: Lee Jones <lee@...nel.org>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Cc: Alice Chen <alice_chen@...htek.com>
> Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Cc: ChiYuan Huang <cy_huang@...htek.com>
> Cc: ChiaEn Wu <chiaen_wu@...htek.com>
> Cc: kernel test robot <lkp@...el.com>
> Cc: linux-leds@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-mediatek@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
-- 
Gustavo

> ---
>   drivers/leds/flash/leds-mt6370-flash.c | 2 +-
>   drivers/leds/rgb/leds-mt6370-rgb.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/flash/leds-mt6370-flash.c b/drivers/leds/flash/leds-mt6370-flash.c
> index 931067c8a75f..912d9d622320 100644
> --- a/drivers/leds/flash/leds-mt6370-flash.c
> +++ b/drivers/leds/flash/leds-mt6370-flash.c
> @@ -81,7 +81,7 @@ struct mt6370_priv {
>   	unsigned int fled_torch_used;
>   	unsigned int leds_active;
>   	unsigned int leds_count;
> -	struct mt6370_led leds[];
> +	struct mt6370_led leds[] __counted_by(leds_count);
>   };
>   
>   static int mt6370_torch_brightness_set(struct led_classdev *lcdev, enum led_brightness level)
> diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
> index bb62431efe83..448d0da11848 100644
> --- a/drivers/leds/rgb/leds-mt6370-rgb.c
> +++ b/drivers/leds/rgb/leds-mt6370-rgb.c
> @@ -153,7 +153,7 @@ struct mt6370_priv {
>   	const struct mt6370_pdata *pdata;
>   	unsigned int leds_count;
>   	unsigned int leds_active;
> -	struct mt6370_led leds[];
> +	struct mt6370_led leds[] __counted_by(leds_count);
>   };
>   
>   static const struct reg_field common_reg_fields[F_MAX_FIELDS] = {