linux-hardening - Re: [PATCH] afs: Annotate struct afs_addr_list with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2023 14:50:51 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kees Cook <keescook@...omium.org>,
        David Howells <dhowells@...hat.com>
Cc:     Marc Dionne <marc.dionne@...istor.com>,
        linux-afs@...ts.infradead.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] afs: Annotate struct afs_addr_list with __counted_by



On 9/15/23 14:14, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct afs_addr_list.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: David Howells <dhowells@...hat.com>
> Cc: Marc Dionne <marc.dionne@...istor.com>
> Cc: linux-afs@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
-- 
Gustavo

> ---
>   fs/afs/internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/afs/internal.h b/fs/afs/internal.h
> index da73b97e19a9..07433a5349ca 100644
> --- a/fs/afs/internal.h
> +++ b/fs/afs/internal.h
> @@ -87,7 +87,7 @@ struct afs_addr_list {
>   	enum dns_lookup_status	status:8;
>   	unsigned long		failed;		/* Mask of addrs that failed locally/ICMP */
>   	unsigned long		responded;	/* Mask of addrs that responded */
> -	struct sockaddr_rxrpc	addrs[];
> +	struct sockaddr_rxrpc	addrs[] __counted_by(max_addrs);
>   #define AFS_MAX_ADDRESSES ((unsigned int)(sizeof(unsigned long) * 8))
>   };
>