linux-hardening - Re: [PATCH] md/md-linear: Annotate struct linear_conf with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW7W8nCYsk_cA1ue=LYcdLhtBSoDnww5b+1RtteudNa0=A@mail.gmail.com>
Date: Fri, 22 Sep 2023 11:27:41 -0700
From: Song Liu <song@...nel.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Kees Cook <keescook@...omium.org>, linux-raid@...r.kernel.org, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] md/md-linear: Annotate struct linear_conf with __counted_by

On Fri, Sep 15, 2023 at 1:27 PM Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
>
>
> On 9/15/23 14:03, Kees Cook wrote:
> > Prepare for the coming implementation by GCC and Clang of the __counted_by
> > attribute. Flexible array members annotated with __counted_by can have
> > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> > functions).
> >
> > As found with Coccinelle[1], add __counted_by for struct linear_conf.
> > Additionally, since the element count member must be set before accessing
> > the annotated flexible array member, move its initialization earlier.
> >
> > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> >
> > Cc: Song Liu <song@...nel.org>
> > Cc: linux-raid@...r.kernel.org
> > Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Applied to md-next. Thanks!
Song