linux-hardening - Re: [PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75f4a4fa-a177-db4a-4653-f121a1e54141@embeddedor.com>
Date: Fri, 22 Sep 2023 20:16:16 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <keescook@...omium.org>, David Airlie <airlied@...il.com>
Cc: Emma Anholt <emma@...olt.net>, Maxime Ripard <mripard@...nel.org>,
 Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org,
 Evan Quan <evan.quan@....com>, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 "Pan, Xinhui" <Xinhui.Pan@....com>, Xiaojian Du <Xiaojian.Du@....com>,
 Huang Rui <ray.huang@....com>, Kevin Wang <kevin1.wang@....com>,
 Hawking Zhang <Hawking.Zhang@....com>,
 Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
 Chris Wilson <chris@...is-wilson.co.uk>,
 John Harrison <john.c.harrison@...el.com>,
 Andi Shyti <andi.shyti@...ux.intel.com>,
 Matthew Brost <matthew.brost@...el.com>, Rob Clark <robdclark@...il.com>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Sean Paul <sean@...rly.run>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Bjorn Andersson <andersson@...nel.org>, Ben Skeggs <bskeggs@...hat.com>,
 Karol Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>,
 David Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Zack Rusin <zackr@...are.com>,
 VMware Graphics Reviewers <linux-graphics-maintainer@...are.com>,
 Melissa Wen <mwen@...lia.com>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>,
 Le Ma <le.ma@....com>, Lijo Lazar <lijo.lazar@....com>,
 Yifan Zhang <yifan1.zhang@....com>, Prike Liang <Prike.Liang@....com>,
 Lang Yu <Lang.Yu@....com>, Tejas Upadhyay <tejas.upadhyay@...el.com>,
 Nirmoy Das <nirmoy.das@...el.com>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Kuogee Hsieh <quic_khsieh@...cinc.com>, linux-kernel@...r.kernel.org,
 amd-gfx@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 nouveau@...ts.freedesktop.org, virtualization@...ts.linux-foundation.org,
 llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with
 __counted_by

On 9/22/23 11:32, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct vc4_perfmon.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Emma Anholt <emma@...olt.net>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
-- 
Gustavo

> ---
>   drivers/gpu/drm/vc4/vc4_drv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
> index bf66499765fb..ab61e96e7e14 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.h
> +++ b/drivers/gpu/drm/vc4/vc4_drv.h
> @@ -76,7 +76,7 @@ struct vc4_perfmon {
>   	 * Note that counter values can't be reset, but you can fake a reset by
>   	 * destroying the perfmon and creating a new one.
>   	 */
> -	u64 counters[];
> +	u64 counters[] __counted_by(ncounters);
>   };
>   
>   struct vc4_dev {