lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee360342-3f39-73ab-fbc4-22cf3899939a@embeddedor.com>
Date: Fri, 22 Sep 2023 19:57:26 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <keescook@...omium.org>, Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Shaokun Zhang <zhangshaokun@...ilicon.com>, netdev@...r.kernel.org,
 linux-parisc@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
 David Ahern <dsahern@...nel.org>, Martin KaFai Lau <martin.lau@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Yisen Zhuang <yisen.zhuang@...wei.com>,
 Salil Mehta <salil.mehta@...wei.com>, Claudiu Manoil
 <claudiu.manoil@....com>, Vladimir Oltean <vladimir.oltean@....com>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Long Li <longli@...rosoft.com>,
 Ajay Sharma <sharmaajay@...rosoft.com>, Alex Elder <elder@...nel.org>,
 Pravin B Shelar <pshelar@....org>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>, Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>,
 Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
 linux-hyperv@...r.kernel.org, linux-rdma@...r.kernel.org,
 dev@...nvswitch.org, llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 13/14] net: tulip: Annotate struct mediatable with
 __counted_by



On 9/22/23 11:28, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct mediatable.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Shaokun Zhang <zhangshaokun@...ilicon.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-parisc@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
-- 
Gustavo

> ---
>   drivers/net/ethernet/dec/tulip/tulip.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
> index 0ed598dc7569..bd786dfbc066 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip.h
> +++ b/drivers/net/ethernet/dec/tulip/tulip.h
> @@ -381,7 +381,7 @@ struct mediatable {
>   	unsigned has_reset:6;
>   	u32 csr15dir;
>   	u32 csr15val;		/* 21143 NWay setting. */
> -	struct medialeaf mleaf[];
> +	struct medialeaf mleaf[] __counted_by(leafcount);
>   };
>   
>   

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ