lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMRc=Md+BM0fGoO9SrnmKOKAmXmMBNJ9aBvuOCfKpT94rhv+zQ@mail.gmail.com> Date: Mon, 25 Sep 2023 09:40:56 +0200 From: Bartosz Golaszewski <brgl@...ev.pl> To: Kees Cook <keescook@...omium.org> Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-i2c@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, linux-hardening@...r.kernel.org Subject: Re: [PATCH] eeprom: at24: Annotate struct at24_data with __counted_by On Fri, Sep 22, 2023 at 7:51 PM Kees Cook <keescook@...omium.org> wrote: > > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct at24_data. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Bartosz Golaszewski <brgl@...ev.pl> > Cc: Arnd Bergmann <arnd@...db.de> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: linux-i2c@...r.kernel.org > Signed-off-by: Kees Cook <keescook@...omium.org> > --- > drivers/misc/eeprom/at24.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index af83aca452b7..7dfd7fdb423e 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -92,7 +92,7 @@ struct at24_data { > * them for us. > */ > u8 bank_addr_shift; > - struct regmap *client_regmaps[]; > + struct regmap *client_regmaps[] __counted_by(num_addresses); > }; > > /* > -- > 2.34.1 > Applied, thanks! Bart
Powered by blists - more mailing lists