lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230925110352.GB846747@linux.intel.com> Date: Mon, 25 Sep 2023 13:03:52 +0200 From: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com> To: Kees Cook <keescook@...omium.org> Cc: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>, Oded Gabbay <ogabbay@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, dri-devel@...ts.freedesktop.org, llvm@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] accel/ivpu: Annotate struct ivpu_job with __counted_by On Fri, Sep 22, 2023 at 10:54:17AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ivpu_job. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com> > Cc: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com> > Cc: Oded Gabbay <ogabbay@...nel.org> > Cc: Nathan Chancellor <nathan@...nel.org> > Cc: Nick Desaulniers <ndesaulniers@...gle.com> > Cc: Tom Rix <trix@...hat.com> > Cc: dri-devel@...ts.freedesktop.org > Cc: llvm@...ts.linux.dev > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com> Please apply the patch via whatever tree is appropriate. Or if I have to take it via drm-misc, please let me know. Regards Stanislaw > --- > drivers/accel/ivpu/ivpu_job.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/ivpu/ivpu_job.h b/drivers/accel/ivpu/ivpu_job.h > index aa1f0b9479b0..5514c2d8a609 100644 > --- a/drivers/accel/ivpu/ivpu_job.h > +++ b/drivers/accel/ivpu/ivpu_job.h > @@ -51,7 +51,7 @@ struct ivpu_job { > u32 job_id; > u32 engine_idx; > size_t bo_count; > - struct ivpu_bo *bos[]; > + struct ivpu_bo *bos[] __counted_by(bo_count); > }; > > int ivpu_submit_ioctl(struct drm_device *dev, void *data, struct drm_file *file); > -- > 2.34.1 >
Powered by blists - more mailing lists