linux-hardening - Re: [PATCH 9/9] drm/v3d: Annotate struct v3d_perfmon with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <708d9fa0-0957-796a-ecc1-9ad4fdae6339@igalia.com>
Date: Thu, 28 Sep 2023 12:16:16 -0300
From: Maira Canal <mcanal@...lia.com>
To: Kees Cook <keescook@...omium.org>, David Airlie <airlied@...il.com>
Cc: Tejas Upadhyay <tejas.upadhyay@...el.com>, Emma Anholt <emma@...olt.net>,
 Tom Rix <trix@...hat.com>, llvm@...ts.linux.dev,
 dri-devel@...ts.freedesktop.org, Chris Wilson <chris@...is-wilson.co.uk>,
 Prike Liang <Prike.Liang@....com>, Huang Rui <ray.huang@....com>,
 Gerd Hoffmann <kraxel@...hat.com>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Matthew Brost <matthew.brost@...el.com>, Karol Herbst <kherbst@...hat.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, amd-gfx@...ts.freedesktop.org,
 Kuogee Hsieh <quic_khsieh@...cinc.com>, Nathan Chancellor
 <nathan@...nel.org>,
 VMware Graphics Reviewers <linux-graphics-maintainer@...are.com>,
 Ben Skeggs <bskeggs@...hat.com>, Andi Shyti <andi.shyti@...ux.intel.com>,
 nouveau@...ts.freedesktop.org, David Airlie <airlied@...hat.com>,
 virtualization@...ts.linux-foundation.org, linux-hardening@...r.kernel.org,
 Lijo Lazar <lijo.lazar@....com>, Yifan Zhang <yifan1.zhang@....com>,
 linux-arm-msm@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
 Kevin Wang <kevin1.wang@....com>, Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Melissa Wen <mwen@...lia.com>, Dmitry Baryshkov
 <dmitry.baryshkov@...aro.org>, Gurchetan Singh
 <gurchetansingh@...omium.org>, Maxime Ripard <mripard@...nel.org>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Evan Quan <evan.quan@....com>,
 Sean Paul <sean@...rly.run>, Tvrtko Ursulin
 <tvrtko.ursulin@...ux.intel.com>, Xiaojian Du <Xiaojian.Du@....com>,
 Le Ma <le.ma@....com>, freedreno@...ts.freedesktop.org,
 Bjorn Andersson <andersson@...nel.org>, "Pan, Xinhui" <Xinhui.Pan@....com>,
 Nick Desaulniers <ndesaulniers@...gle.com>, linux-kernel@...r.kernel.org,
 Alex Deucher <alexander.deucher@....com>, Nirmoy Das <nirmoy.das@...el.com>,
 Lang Yu <Lang.Yu@....com>, Christian König
 <christian.koenig@....com>, John Harrison <john.c.harrison@...el.com>,
 Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH 9/9] drm/v3d: Annotate struct v3d_perfmon with
 __counted_by

Hi Kees,

On 9/22/23 14:32, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct v3d_perfmon.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Emma Anholt <emma@...olt.net>
> Cc: Melissa Wen <mwen@...lia.com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Maíra Canal <mcanal@...lia.com>

Best Regards,
- Maíra

> ---
>   drivers/gpu/drm/v3d/v3d_drv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
> index 7f664a4b2a75..106454f28956 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.h
> +++ b/drivers/gpu/drm/v3d/v3d_drv.h
> @@ -59,7 +59,7 @@ struct v3d_perfmon {
>   	 * values can't be reset, but you can fake a reset by
>   	 * destroying the perfmon and creating a new one.
>   	 */
> -	u64 values[];
> +	u64 values[] __counted_by(ncounters);
>   };
>   
>   struct v3d_dev {