lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <169601242377.3008066.9973846266706309040.b4-ty@chromium.org> Date: Fri, 29 Sep 2023 11:33:46 -0700 From: Kees Cook <keescook@...omium.org> To: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Justin Stitt <justinstitt@...gle.com> Cc: Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, Nick Desaulniers <ndesaulniers@...gle.com> Subject: Re: [PATCH] x86/tdx: refactor deprecated strncpy On Mon, 11 Sep 2023 18:27:25 +0000, Justin Stitt wrote: > `strncpy` is deprecated and we should prefer more robust string apis. > > In this case, `message.str` is not expected to be NUL-terminated as it > is simply a buffer of characters residing in a union which allows for > named fields representing 8 bytes each. There is only one caller of > `tdx_panic()` and they use a 59-length string for `msg`: > | const char *msg = "TD misconfiguration: SEPT_VE_DISABLE attribute must be set."; > > [...] This appears to be trivially correct, so I can take it via my tree. Applied to for-next/hardening, thanks! [1/1] x86/tdx: refactor deprecated strncpy https://git.kernel.org/kees/c/e32c46753312 Take care, -- Kees Cook
Powered by blists - more mailing lists