lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d044b556-d97f-218f-4282-5d87be6a8ef9@embeddedor.com> Date: Sun, 1 Oct 2023 08:53:30 +0200 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Kees Cook <keescook@...omium.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Torsten Schenk <torsten.schenk@...o.com>, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH][next] ALSA: 6fire: Fix undefined behavior bug in struct midi_runtime On 9/29/23 19:27, Kees Cook wrote: > On Fri, Sep 29, 2023 at 06:06:32PM +0200, Gustavo A. R. Silva wrote: >> `struct urb` is a flexible structure, which means that it contains a >> flexible-array member at the bottom. This could potentially lead to an >> overwrite of the objects following `out_urb` in `struct midi_runtime`, >> among them a function pointer. >> >> Fix this by placing the declaration of object `out_urb` at the end of >> `struct midi_runtime`. >> >> Fixes: c6d43ba816d1 ("ALSA: usb/6fire - Driver for TerraTec DMX 6Fire USB") >> Cc: stable@...r.kernel.org >> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org> > > Another good find. :) There are more coming. :) > > Reviewed-by: Kees Cook <keescook@...omium.org> > Thanks! -- Gustavo
Powered by blists - more mailing lists