lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Oct 2023 10:38:11 -0700
From: Kees Cook <>
To: "Gustavo A. R. Silva" <>
Cc: Jan Kara <>,,
Subject: Re: [PATCH][next] udf: Fix undefined behavior bug in struct

On Mon, Oct 02, 2023 at 06:14:26PM +0200, Gustavo A. R. Silva wrote:
> `struct fileIdentDesc` is a flexible structure, which means that it
> contains a flexible-array member at the bottom. This could potentially
> lead to an overwrite of the objects following `fi` in `struct
> udf_fileident_iter` at run-time.
> Fix this by placing the declaration of object `fi` at the end of
> `struct udf_fileident_iter`.
> -Wflex-array-member-not-at-end is coming in GCC-14, and we are getting
> ready to enable it globally.
> Fixes: d16076d9b684 ("udf: New directory iteration code")
> Cc:
> Signed-off-by: Gustavo A. R. Silva <>

Looks right.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists