lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Oct 2023 16:41:50 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: David Rheinsberg <>, Jiri Kosina <>,
	Benjamin Tissoires <>,,,
Subject: Re: [PATCH v2] HID: uhid: replace deprecated strncpy with strscpy

On Tue, Oct 03, 2023 at 09:01:58PM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding.
> Furthermore, let's make sure `hid->xyz` and `ev->` are the
> same size at compile time to prevent silent truncation.
> With these changes, it is abundantly clear what the intent and behavior
> of the code is -- We are getting a string to string copy with
> NUL-termination and no truncation.
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Cc: Kees Cook <>
> Signed-off-by: Justin Stitt <>

Great! This looks much simpler to me. Thanks for adjusting it.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists