lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 3 Oct 2023 16:46:45 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: Arnd Bergmann <>,
	Greg Kroah-Hartman <>,,
Subject: Re: [PATCH v2] drivers: misc: ti-st: replace deprecated strncpy with

On Tue, Oct 03, 2023 at 10:23:07PM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> We expect both `kim_data->dev_name` and `kim_gdata->dev_name` to be
> NUL-terminated.
> `kim_data->dev_name` seems to not require NUL-padding.
> `kim_gdata` is already zero-allocated and as such does not require
> NUL-padding:
> |       kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_KERNEL);
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
> Let's also opt to use the more idiomatic strscpy usage of:
> strscpy(dest, src, sizeof(dest))
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Thanks for the adjustment. This looks right to me now.

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists