lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date: Thu,  5 Oct 2023 21:57:40 +0200
From: Marc Kleine-Budde <>
	Justin Stitt <>,,
	Kees Cook <>,
	Marc Kleine-Budde <>
Subject: [PATCH net-next 05/37] can: peak_pci: replace deprecated strncpy with strscpy

From: Justin Stitt <>

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string

NUL-padding is not required since card is already zero-initialized:
|       card = kzalloc(sizeof(*card), GFP_KERNEL);

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.

Link: [1]
Link: [2]
Signed-off-by: Justin Stitt <>
Reviewed-by: Kees Cook <>
Signed-off-by: Marc Kleine-Budde <>
 drivers/net/can/sja1000/peak_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/sja1000/peak_pci.c b/drivers/net/can/sja1000/peak_pci.c
index 84f34020aafb..da396d641e24 100644
--- a/drivers/net/can/sja1000/peak_pci.c
+++ b/drivers/net/can/sja1000/peak_pci.c
@@ -462,7 +462,7 @@ static int peak_pciec_probe(struct pci_dev *pdev, struct net_device *dev)
 		card->led_chip.owner = THIS_MODULE;
 		card-> = &pdev->dev;
 		card->led_chip.algo_data = &card->i2c_bit;
-		strncpy(card->, "peak_i2c",
+		strscpy(card->, "peak_i2c",
 		card->i2c_bit = peak_pciec_i2c_bit_ops;

Powered by blists - more mailing lists