lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231006201744.work.135-kees@kernel.org> Date: Fri, 6 Oct 2023 13:17:45 -0700 From: Kees Cook <keescook@...omium.org> To: Jani Nikula <jani.nikula@...ux.intel.com> Cc: Kees Cook <keescook@...omium.org>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, John Harrison <John.C.Harrison@...el.com>, Matthew Brost <matthew.brost@...el.com>, Michal Wajdeczko <michal.wajdeczko@...el.com>, Matt Roper <matthew.d.roper@...el.com>, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-hardening@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, Andi Shyti <andi.shyti@...ux.intel.com>, Nirmoy Das <nirmoy.das@...el.com>, Jonathan Cavitt <jonathan.cavitt@...el.com>, Fei Yang <fei.yang@...el.com>, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev Subject: [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct ct_incoming_msg. Cc: Jani Nikula <jani.nikula@...ux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com> Cc: David Airlie <airlied@...il.com> Cc: Daniel Vetter <daniel@...ll.ch> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org> Cc: John Harrison <John.C.Harrison@...el.com> Cc: Matthew Brost <matthew.brost@...el.com> Cc: Michal Wajdeczko <michal.wajdeczko@...el.com> Cc: Matt Roper <matthew.d.roper@...el.com> Cc: intel-gfx@...ts.freedesktop.org Cc: dri-devel@...ts.freedesktop.org Cc: linux-hardening@...r.kernel.org Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] Signed-off-by: Kees Cook <keescook@...omium.org> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index 6e22af31513a..c33210ead1ef 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -96,7 +96,7 @@ struct ct_request { struct ct_incoming_msg { struct list_head link; u32 size; - u32 msg[]; + u32 msg[] __counted_by(size); }; enum { CTB_SEND = 0, CTB_RECV = 1 }; -- 2.34.1
Powered by blists - more mailing lists