lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <07438cd0-0bd2-4505-a787-cc30b2340719@embeddedor.com> Date: Fri, 6 Oct 2023 22:47:35 +0200 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Kees Cook <keescook@...omium.org>, Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-input@...r.kernel.org, linux-hardening@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev Subject: Re: [PATCH] Input: Annotate struct ff_device with __counted_by On 10/6/23 22:17, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ff_device. > > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com> > Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org> > Cc: linux-input@...r.kernel.org > Cc: linux-hardening@...r.kernel.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook <keescook@...omium.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org> Thanks! -- Gustavo > --- > include/linux/input.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/input.h b/include/linux/input.h > index 49790c1bd2c4..de6503c0edb8 100644 > --- a/include/linux/input.h > +++ b/include/linux/input.h > @@ -562,7 +562,7 @@ struct ff_device { > > int max_effects; > struct ff_effect *effects; > - struct file *effect_owners[]; > + struct file *effect_owners[] __counted_by(max_effects); > }; > > int input_ff_create(struct input_dev *dev, unsigned int max_effects);
Powered by blists - more mailing lists