lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <169683193345.43997.16902412199226518649.b4-ty@kernel.org> Date: Mon, 09 Oct 2023 11:42:13 +0530 From: Vinod Koul <vkoul@...nel.org> To: keescook@...omium.org, gustavoars@...nel.org, Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org Subject: Re: [PATCH 1/2] dmaengine: pxa_dma: Remove an erroneous BUG_ON() in pxad_free_desc() On Sat, 07 Oct 2023 13:13:09 +0200, Christophe JAILLET wrote: > If pxad_alloc_desc() fails on the first dma_pool_alloc() call, then > sw_desc->nb_desc is zero. > In such a case pxad_free_desc() is called and it will BUG_ON(). > > Remove this erroneous BUG_ON(). > > It is also useless, because if "sw_desc->nb_desc == 0", then, on the first > iteration of the for loop, i is -1 and the loop will not be executed. > (both i and sw_desc->nb_desc are 'int') > > [...] Applied, thanks! [1/2] dmaengine: pxa_dma: Remove an erroneous BUG_ON() in pxad_free_desc() commit: 83c761f568733277ce1f7eb9dc9e890649c29a8c [2/2] dmaengine: pxa_dma: Annotate struct pxad_desc_sw with __counted_by commit: 0481291f0ccbc5147635cf0eb108f9fe5a05ee7d Best regards, -- ~Vinod
Powered by blists - more mailing lists