linux-hardening - Re: [PATCH] Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 11 Oct 2023 17:40:25 +0000
From: patchwork-bot+bluetooth@...nel.org
To: Kees Cook <keescook@...omium.org>
Cc: luiz.von.dentz@...el.com, twuufnxlz@...il.com, marcel@...tmann.org,
 johan.hedberg@...il.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org, luiz.dentz@...il.com, linux-kernel@...r.kernel.org,
 syzbot+c90849c50ed209d77689@...kaller.appspotmail.com,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_sock: Correctly bounds check and pad
 HCI_MON_NEW_INDEX name

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@...el.com>:

On Wed, 11 Oct 2023 09:31:44 -0700 you wrote:
> The code pattern of memcpy(dst, src, strlen(src)) is almost always
> wrong. In this case it is wrong because it leaves memory uninitialized
> if it is less than sizeof(ni->name), and overflows ni->name when longer.
> 
> Normally strtomem_pad() could be used here, but since ni->name is a
> trailing array in struct hci_mon_new_index, compilers that don't support
> -fstrict-flex-arrays=3 can't tell how large this array is via
> __builtin_object_size(). Instead, open-code the helper and use sizeof()
> since it will work correctly.
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
    https://git.kernel.org/bluetooth/bluetooth-next/c/fbd34cc57479

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html