lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZShM/7mNuBhFTqrm@x130> Date: Thu, 12 Oct 2023 12:46:07 -0700 From: Saeed Mahameed <saeed@...nel.org> To: Kees Cook <keescook@...omium.org> Cc: Justin Stitt <justinstitt@...gle.com>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH] net/mlx5: simplify mlx5_set_driver_version string assignments On 11 Oct 14:34, Kees Cook wrote: >On Wed, Oct 11, 2023 at 09:29:57PM +0000, Justin Stitt wrote: >> In total, just assigning this version string takes: >> (1) strncpy()'s >> (5) strlen()'s >> (3) strncat()'s >> (1) snprintf()'s >> (4) max_t()'s >> >> Moreover, `strncpy` is deprecated [1] and `strncat` really shouldn't be >> used either [2]. With this in mind, let's simply use a single >> `snprintf`. > >Yes, please! readability++ > >> >> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] >> Link: https://elixir.bootlin.com/linux/v6.6-rc5/source/include/linux/fortify-string.h#L448 [2] >> Link: https://github.com/KSPP/linux/issues/90 >> Cc: linux-hardening@...r.kernel.org >> Cc: Kees Cook <keescook@...omium.org> >> Signed-off-by: Justin Stitt <justinstitt@...gle.com> > >Reviewed-by: Kees Cook <keescook@...omium.org> Applied to net-next-mlx5.
Powered by blists - more mailing lists