lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Oct 2023 14:19:13 -0700
From: Kees Cook <>
To: Justin Stitt <>
Cc: Edward Cree <>,
	Martin Habets <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Jakub Kicinski <>, Paolo Abeni <>,,,,
Subject: Re: [PATCH] sfc: replace deprecated strncpy with strscpy

On Thu, Oct 12, 2023 at 08:38:19PM +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> `desc` is expected to be NUL-terminated as evident by the manual
> NUL-byte assignment. Moreover, NUL-padding does not seem to be
> necessary.
> The only caller of efx_mcdi_nvram_metadata() is
> efx_devlink_info_nvram_partition() which provides a NULL for `desc`:
> |       rc = efx_mcdi_nvram_metadata(efx, partition_type, NULL, version, NULL, 0);
> Due to this, I am not sure this code is even reached but we should still
> favor something other than strncpy.
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
> Link: [1]
> Link: [2]
> Link:
> Cc:
> Signed-off-by: Justin Stitt <>

Looks correct to me!

Reviewed-by: Kees Cook <>

Kees Cook

Powered by blists - more mailing lists