lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Oct 2023 22:21:40 +0000
From: Justin Stitt <>
To: Andrew Lunn <>, Heiner Kallweit <>, 
	Russell King <>, "David S. Miller" <>, 
	Eric Dumazet <>, Jakub Kicinski <>, Paolo Abeni <>
Cc:,,, Justin Stitt <>
Subject: [PATCH] net: phy: replace deprecated strncpy with ethtool_sprintf

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this dedicated helper function.

Link: [1]
Link: [2]
Signed-off-by: Justin Stitt <>
Note: build-tested only.

Found with: $ rg "strncpy\("
 drivers/net/phy/nxp-cbtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/nxp-cbtx.c b/drivers/net/phy/nxp-cbtx.c
index 145703f0a406..6a2c0c193255 100644
--- a/drivers/net/phy/nxp-cbtx.c
+++ b/drivers/net/phy/nxp-cbtx.c
@@ -182,7 +182,7 @@ static int cbtx_get_sset_count(struct phy_device *phydev)
 static void cbtx_get_strings(struct phy_device *phydev, u8 *data)
-	strncpy(data, "100btx_rx_err", ETH_GSTRING_LEN);
+	ethtool_sprintf(&data, "100btx_rx_err");
 static void cbtx_get_stats(struct phy_device *phydev,

base-commit: cbf3a2cb156a2c911d8f38d8247814b4c07f49a2
change-id: 20231012-strncpy-drivers-net-phy-nxp-cbtx-c-266285682759

Best regards,
Justin Stitt <>

Powered by blists - more mailing lists