linux-hardening - Re: [PATCH v2] brcmfmac: replace deprecated strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y352nrg.fsf@kernel.org>
Date: Tue, 17 Oct 2023 19:54:11 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Franky Lin <franky.lin@...adcom.com>
Cc: Justin Stitt <justinstitt@...gle.com>,  Arend van Spriel
 <aspriel@...il.com>,  Hante Meuleman <hante.meuleman@...adcom.com>,
  linux-wireless@...r.kernel.org,  brcm80211-dev-list.pdl@...adcom.com,
  SHA-cyfmac-dev-list@...ineon.com,  linux-kernel@...r.kernel.org,
  linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] brcmfmac: replace deprecated strncpy

Franky Lin <franky.lin@...adcom.com> writes:

>  Hi Justin,
>
> On Mon, Oct 16, 2023 at 3:14 PM Justin Stitt <justinstitt@...gle.com> wrote:
>>
>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
>>
>> This patch replaces multiple strncpy uses. For easier reading, I'll list
>> each destination buffer and mention whether it requires either
>> NUL-termination or NUL-padding.
>
> Kudos to the detailed analysis of each instance. One thing I can think
> of to make this better is to split it into smaller patches so if any
> regression is observed, only the specific code causing it needs to be
> reverted. Maybe instance 2, 3, 4 can be handled in one patch since
> they are touching the country code in one file. The other instances
> each can be an individual patch.
>
> The "brcmfmac" in the title is not accurate. The change touches both
> brcmfmac and brcmsmac. So "brcm80211" would be more appropriate.

Please also add "wifi:" to the title, see the wiki link below for more
info.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches